[DPLT-1049] Prevent modification of other schemas during provisioning #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgsmccauley
force-pushed
the
DPLT-1049-prevent-modification-of-other-schemas-during-provisioning
branch
from
bad27cb
to
a42aada
Compare
| SET SCHEMA '${schemaName}'; | ||
|
|
||
| -- indexer provided migration | ||
| ${migration}; |
There was a problem hiding this comment.
Can this be attacked by calling
SET ROLE someotheruser;
SET SCHEMA otherschema
at the start of a migration?
There was a problem hiding this comment.
Just checked, yes it can.. let me try and figure out how to prevent that
There was a problem hiding this comment.
We could disallow SET in schema. There may be other clever syntaxes to do the same thing but it'd be a start. Keeping people from setting config sounds like a good idea as well.
gabehamilton
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's possible to execute any arbitrary SQL during schema provisioning. We set the
search_pathto an schema specific to the indexer, but there's nothing preventing the user from executing SQL against other schemas, i.e.CREATE TABLE other_schema.table ..., orDROP SCHEMA other_schema. To prevent this, we now create a Postgres Role which has access limited to the current schema only.As we only allow creating new schemas, and not updating existing schemas, we shouldn't need to migrate any existing schemas to have a corresponding role.
Additionally, I've:
roleName->hasuraRoleNameto avoid confusion with the PG role